Skip to content

feat: support monero_wallet URI restoration - #1261

Open
sneurlax wants to merge 16 commits into
stagingfrom
feat/monero-uri
Open

feat: support monero_wallet URI restoration#1261
sneurlax wants to merge 16 commits into
stagingfrom
feat/monero-uri

Conversation

@sneurlax

@sneurlax sneurlax commented Feb 22, 2026

Copy link
Copy Markdown
Member

supports seed, view_key only, and spend_key and view_key.

@sneurlax
fix: time wallet uri
c8e50d7 
previously if it had a newline at the beginning it would choke
@sneurlax
feat: allow dashes in wallet uri scheme
2d2a1dd 
monero_wallet worked. now monero-wallet works, too

there's a frustrating variety of xmr wallet uri schemes: some with underscores, some with dashes
sneurlax added a commit to sneurlax/stack_wallet that referenced this pull request Mar 2, 2026
@sneurlax
feat: add monero_wallet: URI scanning for wallet restoration
5ca439f 
closes cypherstack#1261
@sneurlax sneurlax mentioned this pull request Mar 6, 2026
Draft
@sneurlax
sneurlax marked this pull request as draft March 6, 2026 20:01
@sneurlax

sneurlax commented Mar 6, 2026

Copy link
Copy Markdown
Member Author

Conflicts in minor and resolvable ways with #1278 ... converting to a draft for now but this can be merged first

@intangir

intangir commented Mar 29, 2026

Copy link
Copy Markdown

will this allow you to import a monero account from the keys?
also can it allow 12 word seed phrases (following BIP39/HD standards) ? those two features are the main things i'm still hoping stack wallet supports as far as monero

@sneurlax

sneurlax commented May 13, 2026

Copy link
Copy Markdown
Member Author

will this allow you to import a monero account from the keys? also can it allow 12 word seed phrases (following BIP39/HD standards) ? those two features are the main things i'm still hoping stack wallet supports as far as monero

Yes and no: yes it will allow importing via keys (in the form of a URI, anyways), but no it does not allow 12 word BIP39 seeds to be imported, which is separate functionality.

@sneurlax
sneurlax marked this pull request as ready for review May 14, 2026 19:20
@codecov

codecov Bot commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.12004% with 596 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.02%. Comparing base (3248751) to head (abffcdd).
⚠️ Report is 4 commits behind head on staging.

Files with missing lines Patch % Lines
...iew/restore_options_view/restore_options_view.dart 38.51% 182 Missing ⚠️
...t_settings/delete_wallet_recovery_phrase_view.dart 23.60% 123 Missing ⚠️
...et_view/sub_widgets/wallet_keys_desktop_popup.dart 0.00% 80 Missing ⚠️
...wallets/wallet/intermediate/lib_monero_wallet.dart 0.00% 41 Missing ⚠️
lib/services/wallet_recovery_service.dart 0.00% 39 Missing ⚠️
...s_view/wallet_backup_views/wallet_backup_view.dart 45.61% 31 Missing ⚠️
...tore_wallet_view/sub_widgets/restoring_dialog.dart 6.45% 29 Missing ⚠️
...let_view/sub_widgets/delete_wallet_keys_popup.dart 80.88% 13 Missing ⚠️
...gs_wallet_settings/delete_wallet_warning_view.dart 0.00% 9 Missing ⚠️
lib/route_generator.dart 0.00% 9 Missing ⚠️
... and 14 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           staging    #1261      +/-   ##
===========================================
+ Coverage     4.75%    6.02%   +1.26%     
===========================================
  Files         1108     1112       +4     
  Lines       110815   111447     +632     
===========================================
+ Hits          5273     6710    +1437     
+ Misses      105542   104737     -805

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julian-CStack julian-CStack Awaiting requested review from julian-CStack

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sneurlax @intangir